Turn remaining files into TypeScript source #758
Conversation
| export function getBlogPostsByYear({ limit } = {}) { | ||
| export function getBlogPostsByYear(limit?: number) { | ||
| let count = 0; | ||
| return cachedPaths().reduce((years, post) => { | ||
| if (limit != null && count >= limit) { | ||
| if (limit !== undefined && count >= limit) { |
There was a problem hiding this comment.
I believe it's just as easy to make this limit a regular value, and not an object. It makes it a little nicer to type it as well.
| @@ -6,7 +6,7 @@ | |||
| "scripts": { | |||
| "dev": "next dev", | |||
| "build": "next build && npm run build:rss && next export", | |||
| "build:rss": "node ./scripts/generate-rss-feed.js", | |||
| "build:rss": "tsc --outDir dist --noEmit false && sed -i 's/markdown\"/markdown.js\"/g' dist/lib/api.js && node scripts/generate-rss-feed.js", | |||
There was a problem hiding this comment.
This is a small workaround for Webpack not supporting ".js" imports in TypeScript source (TypeScript itself does, but Webpack is the issue here).
Since node with type: module requires full file extensions, I need to rewrite an import in the compiled javascript code.
An alternative would be using something like https://www.npmjs.com/package/tsx or https://www.npmjs.com/package/ts-node to execute TypeScript directly, but I didn't want to add any new dependencies
There was a problem hiding this comment.
Do the npm install and npm run dev commands in the readme still work?
There was a problem hiding this comment.
Yeah, nothing has changed there. npm run build:rss also works as expected
|
I merged the other PR with automatic formatting. Please resolve the merge conflicts. |
junlarsen
force-pushed
the
fix/minimal-typescript-compilation
branch
from
1f6f899
to
3b0e58e
Compare
Thanks! I have resolved the conflicts now |
Hi! This is a small patch for turning the remainder of the source files into TypeScript.
While I was working on this patch, I noticed we're compiling TypeScript with
strict: falsewhich means we lose most of the safety TypeScript gives us. I would be willing to do the necessary changes to enable strict mode in a different patch 😃As with other parts of the codebase, there are a lot of untyped/loosely typed things which I've just left as-is for now. I've left some TODO comments in the relevant places. I would like some feedback before I commit to any larger changes!
Let me know if there are any questions or concerns. Thanks!