Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: # if true { return } is not hidden in html code block #751

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

PeterD1524
Copy link
Contributor

# if true { return } is shown in the code block of the topic page Unit Testing:

Based on #735, # if true { return } was used to let doc tests pass.
The original function to remove # lines does not cover all cases.
This PR fixes that function to match what librustdoc does.

Another forgotten # on the same page:

Also in blog New Timer implementation:

These # lines will be removed by the fixed function.

Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit e8d7458 into tokio-rs:master Feb 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants