Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix env-filter example #3136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix env-filter example #3136

wants to merge 1 commit into from

Conversation

orf
Copy link

@orf orf commented Nov 13, 2024

I just spent quite a bit of time debugging this. The value [span_b{name=\"bob\"}] parses into a literal pattern pattern: "\"bob\"", which does not match info!(name: "span_b", name="bob").

The filter [span_b{name=bob}] correctly parses and correctly matches.

@orf orf requested review from hawkw, davidbarsky and a team as code owners November 13, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadenlnelson kadenlnelson kadenlnelson approved these changes

@hawkw hawkw Awaiting requested review from hawkw hawkw is a code owner

@davidbarsky davidbarsky Awaiting requested review from davidbarsky davidbarsky is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orf @kadenlnelson