Simplify callsite enabled check #3112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoenig10
commented
Oct 18, 2024
Comment on lines
1116
to
+1118
| #[inline] | ||
| pub fn interest(&'static self) -> Interest { | ||
| match self.interest.load(Ordering::Relaxed) { | ||
| pub fn is_enabled(&'static self) -> bool { | ||
| let interest = match self.interest.load(Ordering::Relaxed) { |
There was a problem hiding this comment.
This should preserve the intent of #943. Namely, that the per-callsite cached interest check is still inlined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor to simplify the callsite enabled check in the macros. In particular, it is a bit confusing that the
interest.is_never()condition is in the macro while theinterest.is_always()condition is inis_enabled.