Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add note to examples that they are for tracing 0.2.0 #3099

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

hds
Copy link
Contributor

@hds hds commented Oct 7, 2024

Motivation

It is not uncommon that users who are new to tracing look at the
examples in the master branch of the repository and find that they
don't compile. This is because they are examples which compile with the
code from the master branch, which is for the as yet unreleased tracing
0.2.0 ecosystem.

Users should instead go to the v0.1.x branch to find examples
compatible with the crates published on crates.io.

Solution

This change adds a doc-comment to the beginning of every example file
informing the user of this fact and suggesting that they check out the
v0.1.x branch instead.

It is not uncommon that users who are new to tracing look at the
examples in the `master` branch of the repository and find that they
don't compile. This is because they are examples which compile with the
code from the master branch, which is for the as yet unreleased tracing
0.2.0 ecosystem.

Users should instead go to the `v0.1.x` branch to find examples
compatible with the crates published on crates.io.

This change adds a doc-comment to the beginning of every example file
informing the user of this fact and suggesting that they check out the
`v0.1.x` branch instead.
@hds hds requested review from hawkw, davidbarsky and a team as code owners October 7, 2024 10:40
@davidbarsky davidbarsky merged commit bdbaf80 into master Oct 9, 2024
56 checks passed
@davidbarsky davidbarsky deleted the hds/examples-on-master-are-not-what-you-want branch October 9, 2024 19:31
@hds hds mentioned this pull request Nov 19, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants