stabilize valuable in 0.1.x
#2960
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hds
added a commit
that referenced
this pull request
Nov 21, 2024
Fixes #2960 Co-authored-by: Matthijs Brobbel <[email protected]> Co-authored-by: Hayden Stainsby <[email protected]> Co-authored-by: Eliza Weisman <[email protected]>
hds
added a commit
that referenced
this pull request
Nov 22, 2024
Fixes #2960 Co-authored-by: Matthijs Brobbel <[email protected]> Co-authored-by: Hayden Stainsby <[email protected]> Co-authored-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
valuablesupport has had unstable support for two years now with no major issues. The crate has close to 30 million downloads on crates.io and all its dependants with more than 3 million downloads aretracingin this repository so it is safe to say that some people have used it.There seem to be no blockers so I think that this could be stabilized and given to anyone who has not opted-in into the unstable features.
Solution
The unstable feature checks were removed as well as its mentions. Cargo feature is still present.
Potential Issues
Turning the feature on only for
tracingbut not fortracing-subscriber. There seem to have been instances (here and here) where people did this and then were surprised by the (json) subscriber usingfmt::Debuginstead of a specialized implementation.This can be solved by removing the cargo feature completely without providing an option to opt-out of
valuableusage.This also adds a
~sigil to macros for valuable support. These two changes can be easily split if we put the macro and test changes after the stabilization, but there would be a lot of new feature gaurds (which would hopefully be short-lived).