Error handling, clippy

examples/chat.rs

@@ -141,7 +141,9 @@ impl Shared {
     async fn broadcast(&mut self, sender: SocketAddr, message: &str) {
         for peer in self.peers.iter_mut() {
             if *peer.0 != sender {
-                let _ = peer.1.send(message.into());
+                if let Err(e) = peer.1.send(message.into()) {
+                    tracing::error!("Failed to send message to {}: {:?}", peer.0, e);
+                }
             }
         }
     }

tokio-util/src/compat.rs

@@ -232,7 +232,9 @@ impl<T: tokio::io::AsyncSeek> futures_io::AsyncSeek for Compat<T> {
             *self.as_mut().project().seek_pos = Some(pos);
         }
         let res = ready!(self.as_mut().project().inner.poll_complete(cx));
-        *self.as_mut().project().seek_pos = None;
+        if res.is_ok() {
+            *self.as_mut().project().seek_pos = None;
+        }
         Poll::Ready(res)
     }
 }
@@ -255,7 +257,9 @@ impl<T: futures_io::AsyncSeek> tokio::io::AsyncSeek for Compat<T> {
             Some(pos) => pos,
         };
         let res = ready!(self.as_mut().project().inner.poll_seek(cx, pos));
-        *self.as_mut().project().seek_pos = None;
+        if res.is_ok() {
+            *self.as_mut().project().seek_pos = None;
+        }
         Poll::Ready(res)
     }
 }

tokio/src/runtime/time/entry.rs

@@ -500,7 +500,7 @@ impl TimerEntry {
                 *self.inner.get() = Some(TimerShared::new(shard_id));
             }
         }
-        return inner.as_ref().unwrap();
+     inner.as_ref().unwrap()
     }
 
     pub(crate) fn deadline(&self) -> Instant {

tokio/src/sync/rwlock.rs

@@ -1094,7 +1094,7 @@ impl<T> From<T> for RwLock<T> {
     }
 }
 
-impl<T: ?Sized> Default for RwLock<T>
+impl<T> Default for RwLock<T>
 where
     T: Default,
 {

tokio/tests/io_split.rs

@@ -104,9 +104,7 @@ fn method_delegation() {
         assert_eq!(1, w.write(&[b'x']).await.unwrap());
         assert_eq!(
             2,
-            w.write_vectored(&[io::IoSlice::new(&[b'x'])])
-                .await
-                .unwrap()
+            w.write_vectored(&[io::IoSlice::new(b"x")]).await.unwrap()
         );
         assert!(w.is_write_vectored());
 

tokio/tests/tcp_accept.rs

@@ -54,7 +54,7 @@ struct TrackPolls<'a> {
     listener: &'a mut TcpListener,
 }
 
-impl<'a> Stream for TrackPolls<'a> {
+impl Stream for TrackPolls<'_> {
     type Item = io::Result<(TcpStream, SocketAddr)>;
 
     fn poll_next(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Option<Self::Item>> {