tracing: move tracing instrumentation tests into tokio tests #7007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #6112, tests for the tracing instrumentation were introduced. They had to live in their own test crate under `tokio/tests` because the `tracing-mock` crate that the tests use had not yet been published to crates.io. Now `tracing-mock` has been published to crates.io and so the separate test crate and separate job to run it are no longer necessary. The tracing instrumentation tests can be placed in with the other integration tests in the `tokio` crate. The tests themselves have also been updated to match the changes in the `tracing-mock` API since the version which was being used.
hds
force-pushed
the
hds/tracing-mock-from-crates.io
branch
from
b02c7f5 to
911c6fe
Compare
Darksonn
added
A-tokio
I was just making sure that if these tests fail, CI will fail.
The value isn't stable, and never made sense in the first place (sleep for 7 milliseconds and get a `duration.op` of 8?!?!).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #6112, tests for the tracing instrumentation were introduced. They
had to live in their own test crate under
tokio/testsbecause thetracing-mockcrate that the tests use had not yet been published tocrates.io.
Solution
Now
tracing-mockhas been published to crates.io and so the separatetest crate and separate job to run it are no longer necessary. The
tracing instrumentation tests can be placed in with the other
integration tests in the
tokiocrate.The tests themselves have also been updated to match the changes in the
tracing-mockAPI since the version which was being used.