Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: handle spurious EWOULDBLOCK in io_async_fd #6776

Merged
merged 2 commits into from
Aug 15, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions tokio/tests/io_async_fd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -135,15 +135,17 @@ fn socketpair() -> (FileDescriptor, FileDescriptor) {
fds
}

fn drain(mut fd: &FileDescriptor) {
fn drain(mut fd: &FileDescriptor, mut amt: usize) {
let mut buf = [0u8; 512];
#[allow(clippy::unused_io_amount)]
loop {
while amt > 0 {
match fd.read(&mut buf[..]) {
Err(e) if e.kind() == ErrorKind::WouldBlock => break,
Err(e) if e.kind() == ErrorKind::WouldBlock => {}
Ok(0) => panic!("unexpected EOF"),
Err(e) => panic!("unexpected error: {:?}", e),
Ok(_) => continue,
Ok(x) => {
amt -= x;
continue;
}
hawkw marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
Expand Down Expand Up @@ -219,10 +221,10 @@ async fn reset_writable() {
let mut guard = afd_a.writable().await.unwrap();

// Write until we get a WouldBlock. This also clears the ready state.
while guard
.try_io(|_| afd_a.get_ref().write(&[0; 512][..]))
.is_ok()
{}
let mut bytes = 0;
while let Ok(Ok(amt)) = guard.try_io(|_| afd_a.get_ref().write(&[0; 512][..])) {
bytes += amt;
}

// Writable state should be cleared now.
let writable = afd_a.writable();
Expand All @@ -234,7 +236,7 @@ async fn reset_writable() {
}

// Read from the other side; we should become writable now.
drain(&b);
drain(&b, bytes);

let _ = writable.await.unwrap();
}
Expand Down Expand Up @@ -386,7 +388,10 @@ async fn poll_fns() {
let afd_b = Arc::new(AsyncFd::new(b).unwrap());

// Fill up the write side of A
while afd_a.get_ref().write(&[0; 512]).is_ok() {}
let mut bytes = 0;
while let Ok(amt) = afd_a.get_ref().write(&[0; 512]) {
bytes += amt;
}

let waker = TestWaker::new();

Expand Down Expand Up @@ -446,7 +451,7 @@ async fn poll_fns() {
}

// Make it writable now
drain(afd_b.get_ref());
drain(afd_b.get_ref(), bytes);

// now we should be writable (ie - the waker for poll_write should still be registered after we wake the read side)
let _ = write_fut.await;
Expand Down
Loading