Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: wake DelayQueue when removing last item #6752

Merged
merged 1 commit into from
Aug 6, 2024
Merged

util: wake DelayQueue when removing last item #6752

merged 1 commit into from
Aug 6, 2024

Conversation

madadam
Copy link
Contributor

@madadam madadam commented Aug 6, 2024

Fixes #6751 by waking the stored Waker in remove if queue becomes empty.

@mox692 mox692 added the A-tokio-util Area: The tokio-util crate label Aug 6, 2024
@Darksonn Darksonn changed the title util: wake DelayQueue when removing last item (#6751) util: wake DelayQueue when removing last item Aug 6, 2024
Darksonn
Darksonn approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit 1e798d2 into tokio-rs:master Aug 6, 2024
85 checks passed
@Darksonn Darksonn added the M-time Module: tokio/time label Aug 6, 2024
@tglane tglane mentioned this pull request Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate M-time Module: tokio/time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DelayQueue not woken when last item removed
3 participants
@madadam @Darksonn @mox692