Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace num_cpus with available_parallelism #6709

Merged
merged 1 commit into from
Jul 22, 2024
Merged

chore: replace num_cpus with available_parallelism #6709

merged 1 commit into from
Jul 22, 2024

Conversation

vilgotf
Copy link
Contributor

@vilgotf vilgotf commented Jul 22, 2024

Unblocked now that tokio's MSRV is 1.70. I could also update the internal ::loom function name if you want too.

Closes: #6432

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime labels Jul 22, 2024
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit feb742c into tokio-rs:master Jul 22, 2024
83 checks passed
@Darksonn Darksonn mentioned this pull request Jul 23, 2024
@glandium
Copy link

Technically, wasn't that a breaking change? (something could be depending on tokio = { version = "1", features = ["num_cpus"]})

@Darksonn
Copy link
Contributor

We don't support dependencies on fake features not in this list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use std::thread::available_parallelism() instead of num_cpus
3 participants