metrics: create MetricAtomicUsize for usized-metrics #6598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mox692
added
A-tokio
mox692
reviewed
May 31, 2024
Darksonn
reviewed
May 31, 2024
tokio/src/util/metric_atomics.rs
Outdated
Comment on lines
49
to
56
| cfg_rt! { | ||
| /// `AtomicUsize` for use in metrics. | ||
| /// | ||
| /// This exposes simplified APIs for use in metrics & uses `std::sync` instead of Loom to avoid polluting loom logs with metric information. | ||
| #[derive(Debug, Default)] | ||
| pub(crate) struct MetricAtomicUsize { | ||
| value: std::sync::atomic::AtomicUsize, | ||
| } |
There was a problem hiding this comment.
Does this need to be gated on cfg_rt!? Is the file not already gated on that?
There was a problem hiding this comment.
these are only used from the rt module (by coincidence, the other metrics are all u64) so I gated on rt to avoid dead code warnings.
There was a problem hiding this comment.
Can you add an #[cfg_attr(not(feature = "rt"), allow(dead_code))] on the module instead? The cfg_rt! blocks break rustfmt, so I try to avoid wrapping large blocks in them.
There was a problem hiding this comment.
Or maybe it'd be better to split the file into two and wrap the mod statement in cfg_rt!.
rcoh
force-pushed
the
metric-atomic-usize
branch
2 times, most recently
from
75a6719 to
6839427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#6556 (comment)
Metrics should not use Loom atomics. This clarifies this in code and also gives the opportunity to make a cleaner interface for metrics. We could potentially use this interface in the future to track things like the maximum value etc.
Solution
Introduce
MetricAtomicUsizeas the equivalent ofMetricAtomicU64