style: Rename spawn<T> to spawn<F> #5993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokio::task::spawn_local is generic over F but tokio::task::spawn is generic over T. I think they should match, and F is more descriptive (F for Future).
|
@Noah-Kennedy hi there, really vital PR here :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename tokio::task::spawn to tokio::task::spawn, to match spawn_local.
Motivation
I was flipping back and forth between the docs page for spawn and spawn_local to understand the differences in which constraints they impose upon their future. I thought it was weird that one is generic over T and one over F.
Solution
I think they should match, and F is more descriptive (F for Future).