Skip to content

Commit

Permalink
revert some changes
Browse files Browse the repository at this point in the history
  • Loading branch information
wathenjiang committed Jul 24, 2024
1 parent 5554133 commit 3f7fcdc
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 7 deletions.
14 changes: 9 additions & 5 deletions tokio/src/runtime/time/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -190,18 +190,22 @@ impl Driver {
assert!(!handle.is_shutdown());

// Finds out the min expiration time to park.
let expiration_time = (0..rt_handle.time().inner.get_shard_size())
.filter_map(|id| {
let lock = rt_handle.time().inner.lock_sharded_wheel(id);
lock.next_expiration_time()
})
let locks = (0..rt_handle.time().inner.get_shard_size())
.map(|id| rt_handle.time().inner.lock_sharded_wheel(id))
.collect::<Vec<_>>();

let expiration_time = locks
.iter()
.filter_map(|lock| lock.next_expiration_time())
.min();

rt_handle
.time()
.inner
.next_wake
.store(next_wake_time(expiration_time));
// Safety: After updating the `next_wake`, we drop all the locks.
drop(locks);

match expiration_time {
Some(when) => {
Expand Down
1 change: 0 additions & 1 deletion tokio/src/runtime/time/tests/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,6 @@ fn reset_timer_and_drop() {
.poll_elapsed(&mut Context::from_waker(futures::task::noop_waker_ref()));

entry.as_mut().reset(start + Duration::from_secs(1), true);
drop(entry);
}
});
}
Expand Down
2 changes: 1 addition & 1 deletion tokio/src/runtime/time/wheel/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ impl Wheel {
}

/// Inserts the `entry` to the `Wheel`.
/// Returns the level and slot which `entry` insert into.
/// Returns the level and the slot which `entry` insert into.
///
/// Safety: The `cached_when` of this `entry`` must have been updated to `when`.
unsafe fn inner_insert(
Expand Down

0 comments on commit 3f7fcdc

Please sign in to comment.