Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_unchecked isn't unchecked #74

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Commits on Jan 16, 2021

  1. get_unchecked isn't unchecked

    This can be seen in the assembly generated by the `get_unchecked` function. Although there is no bounds checking on the array, it still checks whether the entry is occupied and so there is a branch and panic handling code due to the use of `unreachable!()`. I think that logically, both kinds of checking are the same type of error (you accessed an invalid index), so it makes sense for `get_unchecked` to do no branches at all, only address arithmetic.
    
    The only open question is whether the documentation should be adjusted to use a term other than "bounds checking" here since the set of valid slab indices is not an interval.
    digama0 authored Jan 16, 2021
    Configuration menu
    Copy the full SHA
    2773b53 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2021

  1. Update MSRV

    digama0 authored Jan 30, 2021
    Configuration menu
    Copy the full SHA
    851fbcb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    85d7d45 View commit details
    Browse the repository at this point in the history
  3. fix for no_std

    digama0 authored Jan 30, 2021
    Configuration menu
    Copy the full SHA
    8d02216 View commit details
    Browse the repository at this point in the history
  4. fix for std/no_std hybrid

    digama0 committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    a3b40c4 View commit details
    Browse the repository at this point in the history
  5. rustfmt

    digama0 committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    1c4839b View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2021

  1. add docs from fd1f687

    digama0 committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    44c276e View commit details
    Browse the repository at this point in the history