chore: improve no_std maintainability:
#1047
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibbz00
force-pushed
the
no_std
branch
2 times, most recently
from
c6b53e6
to
4023a9c
Compare
Similar to how `rustls` does it: https://github.com/rustls/rustls/blob/513e374b2e2ce9f1fb57ac78ab3ca053afc8f133/rustls/src/lib.rs#L353-L359 > ... `extern crate` plus the `#![no_std]` attribute changes the default prelude from `std::prelude` to `core::prelude`. That forces one to _explicitly_ import (`use`) everything that is in `std::prelude` but not in `core::prelude`. This helps maintain no-std support as even developers that are not interested in, or aware of, no-std support and / or that never run `cargo build --no-default-features` locally will get errors when they rely on `std::prelude` API.
Makes it easier to fix tokio-rs#939 because there were places where the prost_path setting was being ignored when direct a direct alloc path would suffice: https://github.com/tokio-rs/prost/blob/691454307ccd2de4c780438da8acf2a1ddd994f6/prost-build/src/code_generator.rs#L648
caspermeijn
requested changes
Jul 20, 2024
| pub enum Data { | ||
| #[prost(message, tag="1")] | ||
| Foo(::prost::alloc::boxed::Box<super::Foo>), |
There was a problem hiding this comment.
I believe the generated code should always use a fully qualified type path, as they could otherwise clash with a user-generated type.
| @@ -0,0 +1,90 @@ | |||
| //! A facade around all the types we need from the `std`, `core`, and `alloc` | |||
| //! crates. This avoids elaborate import wrangling having to happen in every | |||
| //! module. | |||
There was a problem hiding this comment.
I don't like the facade concept. If we keep it, it should work like the ::std::prelude. But I think it is better to be explicit about your dependencies.
| #![doc = include_str!("../../README.md")] | ||
| #![no_std] | ||
|
|
||
| // See: https://github.com/tokio-rs/prost/pull/1047 |
There was a problem hiding this comment.
The code should not refer to Github issues, but instead contain the contents directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how
rustlsdoes it:https://github.com/rustls/rustls/blob/513e374b2e2ce9f1fb57ac78ab3ca053afc8f133/rustls/src/lib.rs#L353-L359