Avoid double panic when queued_spawn is dropped #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure that global statics are dropped after thread locals - ensure that `loom` does not panic inside a panic - add two regression tests for tokio-rs#152
- ensure that loom doesn't double panic on deadlock - add a test to verify that thread locals are properly destructed on spawned threads
adrianheine
force-pushed
the
arc_double_panics
branch
2 times, most recently
from
3807110
to
77cf541
Compare
|
The CI failure is rust-lang/rust#108988. |
adrianheine
force-pushed
the
arc_double_panics
branch
from
77cf541
to
16dfd30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in the spirit of #297 on the quest to avoid double panics.
Edit: This is not only ›in the spirit of‹, it directly depends on it.