Please revert version to 3.3.0 as 3.4.0 breaks things #439

huashengwang1989 · 2021-10-05T03:17:49Z

Hi! please help revert version to 3.3.0 or bump version to 4.0.0 as many modules depending on gl-matrix is using '^'. 3.4.0 results build errors. Great appreciated!

The text was updated successfully, but these errors were encountered:

Selerski · 2021-10-05T10:16:16Z

I have the same issue, a storybook with a map component breaks with this error:

Module not found: Error: Can't resolve 'gl-matrix/mat4' in '/(...)/node_modules/@math.gl/web-mercator/dist/esm'

A quick resolution would be greatly appreciated!

bilalajanjua · 2021-10-05T10:37:28Z

Yup. This must be resolved as a lot of packages are dependent on that. Mostly react-map-gl, deck.gl, nebula.gl etc.

But for the quick and temp fix, yarn resolutions can help by adding following in the package.json file.

"resolutions": {
   "gl-matrix": "3.3.0",
}

p4cm4n · 2021-10-05T10:42:36Z

Came here to post the same, can confirm it works until an official fix

Yup. This must be resolved as a lot of packages are dependent on that. Mostly react-map-gl, deck.gl, nebula.gl etc.

But for the quick and temp fix, yarn resolutions can help by adding following in the package.json file.
"resolutions": {
   "gl-matrix": "3.3.0",
}

pragyakar · 2021-10-05T11:51:57Z

Is there any solution I can use without using yarn?

Yup. This must be resolved as a lot of packages are dependent on that. Mostly react-map-gl, deck.gl, nebula.gl etc.

But for the quick and temp fix, yarn resolutions can help by adding following in the package.json file.
"resolutions": {
   "gl-matrix": "3.3.0",
}

bilalajanjua · 2021-10-05T11:55:17Z

Is there any solution I can use without using yarn?
Yup. This must be resolved as a lot of packages are dependent on that. Mostly react-map-gl, deck.gl, nebula.gl etc.

But for the quick and temp fix, yarn resolutions can help by adding following in the package.json file.
"resolutions": {
   "gl-matrix": "3.3.0",
}

Hi,

Yeah. There is another package which might help you with resolutions. I haven't tried it though, so can't guarantee.

https://www.npmjs.com/package/npm-force-resolutions

ldegen · 2021-10-05T13:47:06Z

@bilalajanjua thx man, you're my saviour. :-)

toji · 2021-10-05T15:31:02Z

I'll unpublish 3.4.0 for now. It looks like the top-of-tree has made changes (see #432 (comment)) that simply aren't going to be backwards compatible with every build system so I'll need to do a major version bump if we're going to publish any new updates. Might not be a bad time to see if there's any other cleanups that need to be done while I'm at it.

toji · 2021-10-05T15:44:29Z

NPM won't let me unpublish 3.4.0 since apparently there's already some dependencies on it 😮 so I've marked it as deprecated instead. It's not clear to me that will resolve the issue with people who have a dependency on ^3.3.0, though, so I'm looking into publishing a new version using an older commit in the repo before the backward compat breaking changes were introduced.

If anyone happens to be able to confirm that the deprecation DID fix the problem for you, though, I'd appreciate hearing it!

bilalajanjua · 2021-10-05T15:50:40Z

NPM won't let me unpublish 3.4.0 since apparently there's already some dependencies on it 😮 so I've marked it as deprecated instead. It's not clear to me that will resolve the issue with people who have a dependency on ^3.3.0, though, so I'm looking into publishing a new version using an older commit in the repo before the backward compat breaking changes were introduced.

If anyone happens to be able to confirm that the deprecation DID fix the problem for you, though, I'd appreciate hearing it!

I guess deprecation will work. I'm gonna quickly verify now.

bilalajanjua · 2021-10-05T16:08:42Z

NPM won't let me unpublish 3.4.0 since apparently there's already some dependencies on it 😮 so I've marked it as deprecated instead. It's not clear to me that will resolve the issue with people who have a dependency on ^3.3.0, though, so I'm looking into publishing a new version using an older commit in the repo before the backward compat breaking changes were introduced.

If anyone happens to be able to confirm that the deprecation DID fix the problem for you, though, I'd appreciate hearing it!

Unfortunately, It seems deprecation doesn't work.

If we simply run:

yarn add gl-matrix

It installs 3.4.0 version although it's deprecated and also shows the deprecation warning.

And if we try to install other packages which are using gl-matrix as a dependency and have set version as:

"gl-matrix": "^3.0.0"

then it is again resolves to the latest version which is 3.4.0.

So I guess, for now the only option is to republish the package with an older commit to resolve this issue.

toji · 2021-10-05T16:11:30Z

Thanks for checking on that, @bilalajanjua. I've just published v3.4.1, which rolls in a few new fixes but avoids the backwards compat breaking change and should resolve the issue with the deprecated package taking priority. Please give it a try and let me know if you run into any additional problems!

JMariano88 · 2021-10-05T16:36:03Z

It works for me now..

JMariano88 · 2021-10-05T16:44:33Z

I used "npm i [email protected]" to restore gl matrix version, I think it's work fine

bilalajanjua · 2021-10-05T16:47:30Z

Thanks for checking on that, @bilalajanjua. I've just published v3.4.1, which rolls in a few new fixes but avoids the backwards compat breaking change and should resolve the issue with the deprecated package taking priority. Please give it a try and let me know if you run into any additional problems!

No problem Brandon.

I tried with the version 3.4.1, but while building the react app with @math.gl as a dependency. I still get the same error i was getting with 3.4.0.

@math.gl is importing the vec2 module as follows, but I guess we can't import it like this in v3.4.1:

import * as vec2 from 'gl-matrix/vec2';

Instead, it has to be imported like this as per new version:

import { vec2 } from 'gl-matrix';

So i guess, version 3.4.1 still doesn't fix the problem.

toji · 2021-10-05T17:24:01Z

Thank you again for helping debug that. I'm not clear on what would cause that difference between 3.3.0 and 3.4.1, as it should have just been some minor fixes and additions to the functions themselves, not how the build was published. I'll continue investigating.

pragyakar · 2021-10-05T17:44:28Z

Can confirm that 3.4.1 did not solve the issue for me either.

bilalajanjua · 2021-10-05T17:48:38Z

Thank you again for helping debug that. I'm not clear on what would cause that difference between 3.3.0 and 3.4.1, as it should have just been some minor fixes and additions to the functions themselves, not how the build was published. I'll continue investigating.

No worries.

Yeah it seems bundling logic also got changed in one of those fixes. I'll also try to find some time to investigate the cause.

donmccurdy · 2021-10-05T17:53:47Z

Just an FYI for anyone using glTF-Transform, gltfjsx, or React Three Fiber — I've pinned @gltf-transform/core and @gltf-transform/functions to ~3.3.0 for the time being. This will indirectly pin gltfjsx and R3F to the older gl-matrix version as well.

toji · 2021-10-05T18:22:50Z

Okay, I suspect that the issue is that I wasn't building with the exact npm dependencies from v3.3.0, and that changed the output format in a breaking way. I've tried to address that, and the changes to dist/gl-matrix look far less disruptive now, but I'd like to try and verify before pushing out yet another npm release.

Is anyone in a position to try the branch https://github.com/toji/gl-matrix/tree/v3.4.x against code that has started failing since 3.4.0 was pushed and verify if it works or fails for you? (Should be able to set the dependency to git://github.com/toji/gl-matrix.git#1841163019f89a6ff6376327948ea14e29bbfc95 temporarily to test, I think?)

bilalajanjua · 2021-10-05T18:27:25Z

@toji I am verifying that.

bilalajanjua · 2021-10-05T18:37:09Z

Okay, I suspect that the issue is that I wasn't building with the exact npm dependencies from v3.3.0, and that changed the output format in a breaking way. I've tried to address that, and the changes to dist/gl-matrix look far less disruptive now, but I'd like to try and verify before pushing out yet another npm release.

Is anyone in a position to try the branch https://github.com/toji/gl-matrix/tree/v3.4.x against code that has started failing since 3.4.0 was pushed and verify if it works or fails for you? (Should be able to set the dependency to git://github.com/toji/gl-matrix.git#1841163019f89a6ff6376327948ea14e29bbfc95 temporarily to test, I think?)

Nope, @toji . That doesn't work as well. Getting the same error as before (#439 (comment)).

toji · 2021-10-05T18:45:06Z

Ugh, thanks for checking.

One last thing, if you don't mind (thank you so much for your help so far!) Can you try git://github.com/toji/gl-matrix.git#93d9f756d7bdc32d163f36d0b8cad74a6a795a98? That's the same commit as v3.3.0 was built from with just a straight up rebuild. I'd like to know if that works, because if not it means I'm not able to rebuild a compatible release. Which... would not be great.

bilalajanjua · 2021-10-05T18:46:22Z

With 3.4.2, here's the intellisense i get:

And here's the package tree:

With 3.3.0, here's the intellisense i get:

And the package tree is as follows:

I noticed that there is no dist folder as well. So something is changed in bundling logic.

bilalajanjua · 2021-10-05T18:47:07Z

Ugh, thanks for checking.

One last thing, if you don't mind (thank you so much for your help so far!) Can you try git://github.com/toji/gl-matrix.git#93d9f756d7bdc32d163f36d0b8cad74a6a795a98? That's the same commit as v3.3.0 was built from with just a straight up rebuild. I'd like to know if that works, because if not it means I'm not able to rebuild a compatible release. Which... would not be great.

Sure @toji, On it.

bilalajanjua · 2021-10-05T18:54:03Z

@toji This seems fine. It generates the same tree that i sent earlier for version 3.3.0. Although it's still under dist folder but i guess with npm publish, dist folder's content will be moved to the root directory. If yes, then it will actually solve the problem.

Here's the tree:

toji · 2021-10-05T19:29:06Z

Thanks again @bilalajanjua. I've published v3.4.2 to NPM and deprecated v3.4.1. This is just the v3.3.0 release with two new functions that will benefit WebGPU developers in the future. Verification that it's working with other projects would be welcome!

(And I'm going to have to set aside some time to do some serious restructuring of the current build system for an eventual 4.0.0 release. I'm very distressed at how brittle it's ended up being, though to be fair it's also been allowed to bit-rot for a while.)

bilalajanjua · 2021-10-05T19:59:57Z

Thanks again @bilalajanjua. I've published v3.4.2 to NPM and deprecated v3.4.1. This is just the v3.3.0 release with two new functions that will benefit WebGPU developers in the future. Verification that it's working with other projects would be welcome!

(And I'm going to have to set aside some time to do some serious restructuring of the current build system for an eventual 4.0.0 release. I'm very distressed at how brittle it's ended up being, though to be fair it's also been allowed to bit-rot for a while.)

@toji I am afraid, v3.4.2 when installed brings dist folder with it and that's why

import * as vec2 from 'gl-matrix/vec2';

doesn't work and

import * as vec2 from 'gl-matrix/dist/vec2';

works! (which is not expected 😟)

I thought bundling actually takes away dist folder and packs only the content inside it as it was previously done in v3.3.0.

toji · 2021-10-05T20:12:12Z

Oh, I may have misunderstood something fairly fundamental about how @stefnotch was previously publishing the package. Let me verify something...

donmccurdy · 2021-10-05T20:18:57Z

In package.json there are mappings from the import names to the files in dist/. Bundlers, and Node.js versions >=v13, should be able to resolve these paths. Related to some issues for TypeScript users: #390, #423. I'm not sure what would happen if your JS code is being compiled to CommonJS before running in Node.js in this case.

gl-matrix/package.json

Lines 9 to 21 in 0bca31a

    
           "exports": { 
        
             ".": "./dist/esm/index.js", 
        
             "./common": "./dist/esm/common.js", 
        
             "./mat2": "./dist/esm/mat2.js", 
        
             "./mat2d": "./dist/esm/mat2d.js", 
        
             "./mat3": "./dist/esm/mat3.js", 
        
             "./mat4": "./dist/esm/mat4.js", 
        
             "./quat": "./dist/esm/quat.js", 
        
             "./quat2": "./dist/esm/quat2.js", 
        
             "./vec2": "./dist/esm/vec2.js", 
        
             "./vec3": "./dist/esm/vec3.js", 
        
             "./vec4": "./dist/esm/vec4.js" 
        
           },

toji · 2021-10-05T20:19:09Z

Well crap. Turns out that the previous npm packages were being published FROM the dist folder, whereas I was publishing from the root.

...sigh

v3.4.3 has been published now (sure, let's just burn through ALL the 3.4.x's why don't we.) Let's give that a try.

(I apologize that this has been so much back and forth. I include gl-matrix in my own projects as a ES module and so the depenencies work out differently.)

stefnotch · 2021-10-05T20:19:24Z

Oh dearie, I'm very sorry for not properly documenting everything. If I recall correctly, I was publishing the package by doing

npm install
cd dist
npm publish

I'm not entirely sure why I had to cd into the dist directory for everything to work.

It's also quite possible that one of the build system changes that I merged in was backwards incompatible.

toji · 2021-10-05T20:21:04Z

No, this really isn't your fault. If anything it's entirely due to my lack of activity on the project lately. I can see why the builds were being published that way now, it just wasn't what I remembered/expected based on some of the other NPM packages I've had a more hands-on involvement in lately.

bilalajanjua · 2021-10-05T20:24:38Z

Thanks guys @toji @stefnotch @donmccurdy 🚀

I can confirm v3.4.3 works perfectly fine just like 3.3.0

P.S. These last few comments gave me an idea on how to publish a package without that dist folder. So yeah thanks for that. 😄

toji · 2021-10-05T20:27:20Z

Hallelujah! Thank you for taking the time to help me set that right, it's been invaluable.

And now that I know what went wrong I can push out fixes more confidently in the future. Again, though, it may be best if I leave any big changes to a potential 4.0.0 just to avoid this whole song and dance.

InCogNiTo124 · 2022-02-13T19:21:55Z

I'm having trouble with 3.4.3 ☹️ but I have a specific setup because I'm developing in a development docker container:

I'm trying to setup this folder:https://github.com/davidwparker/programmingtil-webgl/tree/master/0063-3d-cube-mouse-rotate

I've obtained gl-matrix:3.4.3 from npm by npm install -g gl-matrix and copying /usr/local/lib/node_modules/gl-matrix/gl-matrix-min.js into my folder:

.
├── css
│   └── styles.css
├── gl-matrix-min.js
├── index.html
├── index.js
├── libs
│   ├── glUtils.js
│   └── uiUtils.js
├── README.md
├── shaders
│   ├── fragment.glsl
│   └── vertex.glsl
└── signals.min.js

and I edited the index.html to fix the paths

however, running http-server (as is suggested by readme) from this folder results with:

Uncaught ReferenceError: mat4 is not defined
    at draw (index.js:125:15)
    at Object.state.animation.tick (index.js:97:7)
    at animate (index.js:100:21)
    at main (index.js:62:5)
    at callback (index.js:54:43)
    at h.execute (signals.min.js:9:20)
    at e.dispatch (signals.min.js:13:106)
    at e.dispatch (signals.min.js:8:368)
    at Object.checkForComplete (glUtils.js:228:27)
    at processShader (glUtils.js:241:18)

Everything is correctly loaded, no 404's.

edit: 3.3.0 still doesn't work as well, though, I may have bumped this unnecessarily

InCogNiTo124 · 2022-02-13T19:22:57Z

BTW I belive you haven't released a git 3.4.3 release 😅

n7best mentioned this issue Oct 5, 2021

🐛 [BUG] gl-matrix模块文件路径更改导致运行项目打包时报引用路径错误 antvis/G2Plot#2889

Closed

DannyvanderJagt mentioned this issue Oct 5, 2021

Cannot find module 'gl-matrix/vec3' pmndrs/gltfjsx#116

Open

donmccurdy mentioned this issue Oct 5, 2021

gltf-transform cli cannot start with node16. Is there a certain node version which I have to use? donmccurdy/glTF-Transform#376

Closed

This was referenced Oct 5, 2021

Updating deckgl package cause dependency errors visgl/deck.gl#6269

Closed

viewport-mercator-project dependency causing crash in Vercel visgl/react-map-gl#1585

Closed

kylebarron mentioned this issue Oct 5, 2021

Pin gl-matrix to ~3.3.0 uber-web/math.gl#253

Merged

toji closed this as completed Oct 5, 2021

monolithed mentioned this issue Oct 6, 2021

引用G6报错 dependencies were not found：gl-matrix/vec2 gl-matrix/vec3 antvis/G6#3236

Closed

JonasJonny mentioned this issue Jan 3, 2022

The lastest version will cause the error occured in build，please pay attention to it privateOmega/html-to-docx#112

Closed

This was referenced Jan 25, 2023

Breaking change: 3.4.3 no longer has exports in package.json #444

Open

ES Module Support #455

Open

Please revert version to 3.3.0 as 3.4.0 breaks things #439

Please revert version to 3.3.0 as 3.4.0 breaks things #439

Comments

huashengwang1989 commented Oct 5, 2021

Selerski commented Oct 5, 2021 • edited Loading

bilalajanjua commented Oct 5, 2021

p4cm4n commented Oct 5, 2021

pragyakar commented Oct 5, 2021

bilalajanjua commented Oct 5, 2021

ldegen commented Oct 5, 2021

toji commented Oct 5, 2021

toji commented Oct 5, 2021

bilalajanjua commented Oct 5, 2021

bilalajanjua commented Oct 5, 2021

toji commented Oct 5, 2021

JMariano88 commented Oct 5, 2021

JMariano88 commented Oct 5, 2021

bilalajanjua commented Oct 5, 2021 • edited Loading

toji commented Oct 5, 2021

pragyakar commented Oct 5, 2021

bilalajanjua commented Oct 5, 2021

donmccurdy commented Oct 5, 2021 • edited Loading

toji commented Oct 5, 2021

bilalajanjua commented Oct 5, 2021

bilalajanjua commented Oct 5, 2021 • edited Loading

toji commented Oct 5, 2021

bilalajanjua commented Oct 5, 2021

bilalajanjua commented Oct 5, 2021

bilalajanjua commented Oct 5, 2021 • edited Loading

toji commented Oct 5, 2021

bilalajanjua commented Oct 5, 2021

toji commented Oct 5, 2021

donmccurdy commented Oct 5, 2021 • edited Loading

toji commented Oct 5, 2021

stefnotch commented Oct 5, 2021 • edited Loading

toji commented Oct 5, 2021

bilalajanjua commented Oct 5, 2021

toji commented Oct 5, 2021

InCogNiTo124 commented Feb 13, 2022 • edited Loading

InCogNiTo124 commented Feb 13, 2022

Selerski commented Oct 5, 2021 •

edited

Loading

bilalajanjua commented Oct 5, 2021 •

edited

Loading

donmccurdy commented Oct 5, 2021 •

edited

Loading

bilalajanjua commented Oct 5, 2021 •

edited

Loading

bilalajanjua commented Oct 5, 2021 •

edited

Loading

donmccurdy commented Oct 5, 2021 •

edited

Loading

stefnotch commented Oct 5, 2021 •

edited

Loading

InCogNiTo124 commented Feb 13, 2022 •

edited

Loading