-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gltf-transform cli cannot start with node16. Is there a certain node version which I have to use? #376
Comments
I have exactly same issue while using it in script by importing things - #375 , also on Node 16.x. I wasted half a day on trying to make it work :/ It looks like it's trying to use |
To make it even more weird ... Today on other machines not anymore .... really spooky |
I found the issue... Its gl-matrix 3.4.0. It works fine, if I use gl-matrix 3.3.0. Currently I just copied it into the project-folder/cli/node_modules. Then it starts fine. Yeah, a new gl-matrix version (3.4.0) was published 14 hours ago: Thats why the error only appears now. |
The integration tests check Node.js v12 and v14 so probably those are the safest options. I'll try adding v16 to the tests and see what happens – was v16 working before the gl-matrix dependency update for anyone? It looks like gl-matrix has already gotten reports about this (toji/gl-matrix#439) and are planning to revert 3.4.0 shortly. I'll see about switching this project's production dependencies to |
Ok, so they published new version for gl-matrix (v3.4.1), but the problem remains, only solution for now is to revert to [email protected] |
It looks like v3.4.1 fixed this for some others (toji/gl-matrix#439 (comment))... gltfjsx has dependencies:
Seems like there may be bigger changes still in v3.4.1 than I want to have roll out automatically (https://github.com/toji/gl-matrix/releases/tag/v3.4.1), I'll deploy a patch release pinned to 3.3.x instead. |
I've just published v0.12.16, pinned to gl-matrix@~3.3.0. Hopefully that fixes the regression, but let me know if not! Have also added integration test coverage for Node.js v16, which seems to be working fine. |
Thx for the fast fix! |
Hi!
After running this command: npm install --global @gltf-transform/cli
I would like to start the gltf-transform cli, but then this error appears:
To Reproduce
Expected behavior
No error..
Versions:
The text was updated successfully, but these errors were encountered: