Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language and net examples #3

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Language and net examples #3

wants to merge 11 commits into from

Conversation

jacobqvist
Copy link
Contributor

No description provided.

@jacobqvist jacobqvist requested a review from floitsch September 14, 2021 09:44
Copy link
Member

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Would probably make sense to "backport" some of my comments to the examples from the net library.


bytes := 0
while data := response.read:
bytes += data.size
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our example should do more.
Now I would need to look up another example to figure out how to actually deal with the data.
If you know how to easily handle the data, it should be trivial to change it to something more useful.
If you don't then it shows that we are missing something here... ;)

Suggested change
bytes += data.size
// Discard the data from the server, and just count the number of bytes.
bytes += data.size

jacobqvist and others added 7 commits September 14, 2021 12:36
Co-authored-by: Florian Loitsch <[email protected]>
Co-authored-by: Florian Loitsch <[email protected]>
Co-authored-by: Florian Loitsch <[email protected]>
Co-authored-by: Florian Loitsch <[email protected]>
Co-authored-by: Florian Loitsch <[email protected]>
Co-authored-by: Florian Loitsch <[email protected]>
Co-authored-by: Florian Loitsch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants