This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
[WIP] Use a enum-based Error type instead of one based on std::string #3772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
Switch from a std::string-based error type to a class with an enumeration (lib)
This is by no means done (now the UI is getting a ton of Unknown errors) but now it finally compiles and I need to store it somewhere before I go completely mad.
One important thing worth noting is that the way we're doing exception handling now is absolutely insane. Catch-them-all clauses and then searching the reason string for patterns is just about the worst error handling method I've ever seen. I'll need to figure out how to continue from here...
For now, I'm thinking about adding a
details
field to theError
class and continue using this new class in a way very similar to how the oldtypedef std::string error
was used so we maintain some degree of compatibility with the old solution while we're slowly progressing to a cleaner solution. This is a pretty big undertaking on itself though.🕶️ Types of changes
🔎 Review hints
This will be tough to review.
There are a few error types we had before:
const.h
properly==
and notstd::string::find