Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(edgeless): mind map collapse #8905

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(edgeless): mind map collapse #8905

wants to merge 2 commits into from
+1,176 −308

Conversation

doouding
Copy link
Member

@doouding doouding commented Dec 9, 2024 •
edited
Loading

Changed

  • Add mind map collapsed feature
  • Add propsUpdated slot on canvas element model
  • Remove cursorUpdated slot, use gfx.cursor$ instead
  • Move canvas renderer depended slots listener into itself
  • Add responseExtension to GfxCompatibleInterface, which used to expand the hit-testing area

@vercel Vercel
Copy link

vercel bot commented Dec 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 7:49am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 7:49am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c523d6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 9, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@doouding doouding mentioned this pull request Dec 9, 2024
Merged
@doouding Graphite App
Copy link
Member Author

doouding commented Dec 9, 2024 •
edited
Loading

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@doouding doouding mentioned this pull request Dec 9, 2024
Merged
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 9, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c523d6c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@doouding doouding changed the title feat: add basic button render feat: mind map collapse Dec 9, 2024
@doouding doouding force-pushed the 12-06-feat_canvas_event_support branch from b7b2b40 to b204cec Compare December 9, 2024 09:45
@doouding doouding force-pushed the 12-09-feat_mind_map_collapse branch from 9b93621 to ca1ac30 Compare December 9, 2024 09:45
@doouding doouding changed the title feat: mind map collapse feat: mind map collapse Dec 9, 2024
@doouding doouding force-pushed the 12-06-feat_canvas_event_support branch from b204cec to 35b315f Compare December 9, 2024 09:53
@doouding doouding force-pushed the 12-09-feat_mind_map_collapse branch from ca1ac30 to 6c55213 Compare December 9, 2024 09:53
@doouding doouding force-pushed the 12-06-feat_canvas_event_support branch from 35b315f to df7c1ed Compare December 9, 2024 10:43
@doouding doouding force-pushed the 12-09-feat_mind_map_collapse branch from 6c55213 to e57e4df Compare December 9, 2024 10:43
@doouding doouding force-pushed the 12-06-feat_canvas_event_support branch from df7c1ed to 15992c9 Compare December 9, 2024 15:02
@doouding doouding force-pushed the 12-09-feat_mind_map_collapse branch from e57e4df to ea53793 Compare December 9, 2024 15:02
@doouding doouding force-pushed the 12-09-feat_mind_map_collapse branch from 5929ec2 to 26fe8cf Compare December 17, 2024 10:02
@doouding doouding marked this pull request as ready for review December 17, 2024 10:04
@doouding doouding requested a review from a team as a code owner December 17, 2024 10:04
@doouding doouding force-pushed the 12-09-feat_mind_map_collapse branch from 26fe8cf to 6390a17 Compare December 17, 2024 10:09
@doouding doouding requested review from doodlewind and L-Sun December 18, 2024 02:25
@doouding doouding force-pushed the 12-06-feat_canvas_event_support branch 2 times, most recently from a7a07eb to fe3d272 Compare December 18, 2024 02:44
@doouding doouding force-pushed the 12-09-feat_mind_map_collapse branch 2 times, most recently from 4cda4d2 to e4ed3d0 Compare December 18, 2024 02:49
L-Sun
L-Sun reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@L-Sun L-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected remaining node after collapsing parent node

CleanShot.2024-12-18.at.10.56.54.mp4

@doouding doouding changed the base branch from 12-06-feat_canvas_event_support to graphite-base/8905 December 18, 2024 03:48
@doouding doouding force-pushed the 12-09-feat_mind_map_collapse branch from e4ed3d0 to c08c600 Compare December 18, 2024 03:54
@doouding doouding changed the base branch from graphite-base/8905 to master December 18, 2024 03:54
@doouding doouding force-pushed the 12-09-feat_mind_map_collapse branch from c08c600 to 6be9e2d Compare December 18, 2024 03:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.11 MB (+0.16% 🔺)
@blocksuite/affine/block-std 158.54 KB (+0.06% 🔺)
@blocksuite/affine/block-std/gfx 82.56 KB (+0.15% 🔺)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.9 KB (+0.2% 🔺)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.66 KB (0%)
@blocksuite/affine/inline 32.66 KB (0%)
@blocksuite/affine/inline/consts 242 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.9 MB (+0.15% 🔺)
@blocksuite/affine/blocks 2 MB (+0.12% 🔺)
@blocksuite/affine/blocks/schemas 88.96 KB (-1.11% 🔽)

@doouding Graphite App
Copy link
Member Author

Unexpected remaining node after collapsing parent node

CleanShot.2024-12-18.at.10.56.54.mp4

Thanks, I've fixed it.

@doouding doouding requested a review from L-Sun December 18, 2024 08:14
@fundon
Copy link
Contributor

fundon commented Dec 18, 2024

Sometimes it goes into edgeless-text.

Screen.Recording.2024-12-18.at.16.15.24.mov

@doouding Graphite App
Copy link
Member Author

Sometimes it goes into edgeless-text.

I think this is expected behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@doodlewind doodlewind Awaiting requested review from doodlewind

@L-Sun L-Sun Awaiting requested review from L-Sun

At least 1 approving review is required to merge this pull request.

Assignees

@doouding doouding

Labels
None yet
Projects
BlockSuite Project
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doouding @fundon @L-Sun