-
-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blocks): microsheet-block init #8687
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@raintoway is attempting to deploy a commit to the toeverything Team on Vercel. A member of the Team first needs to authorize it. |
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0d8d561. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
hi @raintoway Thank you for your contributions! They’re really impressive. However, on the UI side, we’d suggest using our new CSS variables prefixed with --affine-v2 for specific variable names. As for the feature side, we believe that only basic text (with multi-format options) and an inline view block type for @ linked docs are needed; additional types aren’t necessary. |
i got the point about the UI side, but the feature side, well.. u mean only basic text and inline-view of @ linked docs in cell is enough ? just like database-block ?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your significant contribution with the microsheet-block
! We truly appreciate the time and effort you've invested in this feature.
After careful review, we have some concerns about merging this as a first-party block. The current implementation includes substantial code duplication from the database block (around 15,000 lines), which would create significant maintenance challenges. As a first-party block that would be released in Affine, we need to ensure long-term maintainability and backward compatibility due to our local-first approach.
For major features like this, we typically encourage discussing the implementation approach with the core team beforehand. Historical experience has shown that large features merged without prior alignment often become challenging to maintain over time.
We would love to see this work continue as part of the blocksuite-examples
repository instead. This would allow the community to benefit from your implementation while providing more flexibility for experimentation and iterations, without the constraints of first-party block maintenance requirements.
We're happy to provide guidance on moving the implementation to blocksuite-examples
. Would you be interested in exploring this path forward?
yeh ,i am interested in exploring this path forward. And, I would appreciate it if this pull request could remain open for more people to discover it . |
Description
A block contains other block, is useful for user to organize their thoughts. easy to access the structure of author's thoughts.
this block is used by my organization frequently and stably
Feature
Yjs
as much as possiblemicrosheet-block
from part of othermicrosheet-block's
areaMore
As a block-based document system, I believe the richness of blocks is very important, as it directly relates to the user experience.
this block can attract users' preferences and
engage more users
, which is useful to commercialization processPs
if u agree this block , e2e test and unit test will coming soon