Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix color palette types #9191

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Dec 18, 2024

Copy link
Contributor Author

fundon commented Dec 18, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.74%. Comparing base (c31e9fd) to head (338724e).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9191      +/-   ##
==========================================
- Coverage   65.78%   65.74%   -0.05%     
==========================================
  Files         727      727              
  Lines       41382    41382              
  Branches     4090     4090              
==========================================
- Hits        27223    27205      -18     
- Misses      13727    13745      +18     
  Partials      432      432              
Flag Coverage Δ
server-test 78.20% <ø> (-0.07%) ⬇️
unittest 35.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/12_18_fix_color_palette_types branch from aa95267 to 628f76a Compare December 18, 2024 02:50
@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:env mod:component app:electron Related to electron app mod:dev labels Dec 18, 2024
@fundon fundon force-pushed the fundon/12_18_fix_color_palette_types branch from 628f76a to f44e6b6 Compare December 18, 2024 03:00
@fundon fundon changed the title fix(core): color palette types fix(core): fix color palette types Dec 18, 2024
@fundon fundon force-pushed the fundon/12_18_fix_color_palette_types branch from f44e6b6 to 2f50643 Compare December 18, 2024 03:03
@fundon fundon force-pushed the fundon/12_18_fix_color_palette_types branch from 2f50643 to 338724e Compare December 18, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:component mod:dev mod:env mod:infra Environment related issues and discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant