DeferredCall: Port to SingleThreadValue
#4566
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kernel
chips/nrf
This removes the static muts and uses STV instead.
bradjc
force-pushed
the
single-thread-value-atomics-deferred-call
branch
from
9368a5e to
0df0209
Compare
github-actions
bot
added
WG-OpenTitan
30 tasks
jrvanwhy
reviewed
Oct 23, 2025
| /// # Safety | ||
| /// | ||
| /// Callers of this function must ensure that this function is never called | ||
| /// concurrently with other calls to [`initialize_debug_writer_wrapper_unsafe`]. |
There was a problem hiding this comment.
Callers also need to avoid calling this concurrently with initialize_debug_writer_wrapper().
| /// # Safety | ||
| /// | ||
| /// Callers of this function must ensure that this function is never called | ||
| /// concurrently with other calls to [`initialize_deferred_call_state_unsafe`]. |
There was a problem hiding this comment.
Same here: callers cannot call this concurrently with initialize_deferred_call_state.
| bit | ||
| if let Some(defcalls_cell) = DEFCALLS.get() { | ||
| defcalls_cell.map_or(None, |defcalls| { | ||
| if let Some(bitmask) = BITMASK.get() { |
There was a problem hiding this comment.
if let Some(bitmask) = BITMASK.get() else { return None };
/* Rest of closure */| } | ||
|
|
||
| // Allow dead code because we need the `Chip` type but don't use `chip`. | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
I don't see any reference to Chip in this file. What changed to require this annotation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This is an example of using SingleThreadValue for DeferredCall. This is implemented on top of
#4551#4624.Testing Strategy
TODO or Help Wanted
I don't know if there is a way to check that these functions are always called in every tock build.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.