feat(optimizer)!: annotate type for Snowflake REGEXP_SUBSTR_ALL function #5979
+41
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-BradfordPaskewitz
requested review from
georgesittas and
fivetran-amrutabhimsenayachit
sqlglot/dialects/snowflake.py
Outdated
Comment on lines
758
to
768
| "REGEXP_SUBSTR_ALL": _build_regexp_extract(exp.RegexpExtractAll), | ||
| "REGEXP_SUBSTR_ALL": _build_regexp_extract(exp.RegexpSubstrAll), |
There was a problem hiding this comment.
Why does this need to change? REGEXP_SUBSTR_ALL is an alias to REGEXP_EXTRACT_ALL.
There was a problem hiding this comment.
Hmm good point. What should I do for situations like this? Just leave the existing business logic and add new tests for REGEXP_SUBSTR_ALL to annotate_functions.sql?
There was a problem hiding this comment.
Got it, thanks, that makes sense. Updated
fivetran-BradfordPaskewitz
force-pushed
the
brad/snowflake_regexp_substr_all
branch
from
cc3eeab to
3b6c982
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links https://fivetran.atlassian.net/browse/RD-1038557
Documentation: https://docs.snowflake.com/en/sql-reference/functions/regexp_substr_all
Confirmed function is not supported by BigQuery, Redshift, PostgreSQL, Databricks, DuckDB, TSQL