avoid using Data::Dumper for Perl OBJECT refs #178
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data::Dumper (at least as of 2.192, which is in the Perl git repo) doesn't support the new SVt_PVOBJ type, and generates a warning when it encounters it. It does actually return something, but the warning can be quite annoying. This commit special cases reftypes of 'OBJECT', avoiding use of Data::Dumper altogether.
Contributor
Author
|
Sorry, this doesn't quite work for nested structures which contain perl objects. I guess the only way to deal with that is by suppressing the warning message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data::Dumper (at least as of 2.192, which is in the Perl git repo) doesn't support the new SVt_PVOBJ type, and generates a warning when it encounters it. It does actually return something, but the warning can be quite annoying.
This commit special cases reftypes of 'OBJECT', avoiding use of Data::Dumper altogether.
An alternative might be to filter out warnings for SVt_PVOBJ, but that seems an iffy approach.
I didn't add a test, as I'm not quite sure where it should go.