fix(dev): add port 9000 preflight, recommend Nix devshell, add DEV_SETUP.md (fixes #11) - #17
Open
chiang21fcb wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and value
Fixes #11: three concrete improvements to make the build setup more hermetic and contributor-friendly.
Changes
Port 9000 preflight check in
justfiledev-store: verifies port 9000 is free before starting rustfs. Fails fast with a clear error message and platform-specific fix instructions when the port is in use (common with Zscaler and other corporate tools on macOS).README now recommends
nix developas the canonical path (it already pins all tools), with a link todocs/DEV_SETUP.mdfor the bring-your-own-tools fallback.New
docs/DEV_SETUP.md: per-platform tool installation instructions for macOS (Apple Silicon), Ubuntu/Debian, and Arch Linux, plus a verification checklist.Scope
dev-store(thesetsid//run/user/$UIDpath). That is a larger change best addressed separately.Stability impact
dev-store, which is a local development recipeTests run
just testnot run locally (requires Rust toolchain and protoc)Visual evidence
Not applicable.
Checklist