Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return null instead of [] for empty <AttributeValue /> #533

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Return null instead of [] for empty <AttributeValue /> #533

wants to merge 4 commits into from

Commits on Jan 8, 2024

  1. Fix formatting typo

    @sambostock
    sambostock committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    d85a5db View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Add missing attribute to xml

    @sambostock
    sambostock committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    0f731c5 View commit details
    Browse the repository at this point in the history

  2. Add test for valueless attribute 

    Sometimes, the SAML server may not have an attribute value for a
particular user:

    <saml:Attribute Name="missing" NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:basic">
      <saml:AttributeValue xsi:type="xs:string" />
    </saml:Attribute>

This adds an additional assertion, documenting the existing behavior.
    @sambostock
    sambostock committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    98cc61f View commit details
    Browse the repository at this point in the history

  3. Return null instead of [] for valueless attribute 

    Sometimes, the SAML server may not have an attribute value for a
particular user:

    <saml:Attribute Name="missing" NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:basic">
      <saml:AttributeValue xsi:type="xs:string" />
    </saml:Attribute>

This changes the value returned in this case from `[]` to `null`.
    @sambostock
    sambostock committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    dc61323 View commit details
    Browse the repository at this point in the history