Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect frameworks to upload/download from .version-file. #95

Open
vgorloff opened this issue Jul 24, 2017 · 0 comments
Open

Comments

@vgorloff
Copy link

Enhancement Suggestion

Automatically detect frameworks to upload/download from .version-file.

Steps which explain the enhancement

  1. Say you have file Carthage.resolved with the following contents github "facebook/facebook-ios-sdk" "sdk-version-4.21.0"
  2. Dependency facebook-ios-sdk produces 3 frameworks during build process: FBSDKLoginKit.framework, FBSDKShareKit.framework, FBSDKCoreKit.framework.
  3. Carthage generates .facebook-ios-sdk.version file with the following contents:
{
  "commitish" : "sdk-version-4.21.0",
  "iOS" : [
    {
      "hash" : "c22ab9aaf5b3049b6a5ce2387c714525a163d8b942f6d3d93ce533d37353d282",
      "name" : "FBSDKLoginKit"
    },
    {
      "hash" : "ca63365bfc88e599656c74a3e44b233b97b0dbb845b6ef1bf5df87db05baf023",
      "name" : "FBSDKShareKit"
    },
    {
      "hash" : "47de2a67234abb2245692056fc633c88bb4704bb68a66592fc991f538aa62665",
      "name" : "FBSDKCoreKit"
    }
  ]
}

Current and suggested behavior

Currently we have to setup configuration setting RepositoryMap to hint Rome which files to use during download/upload.

[RepositoryMap]
    facebook-ios-sdk = FBSDKCoreKit, FBSDKLoginKit, FBSDKShareKit

I am suggesting to update Rome in the way so that it will read framework names from .version-file. In this case we do not need to use RepositoryMap configuration setting in order to hint Rome which files to use during download/upload.

Why would the enhancement be useful to most users

Users will have better user experience and less configuration to setup. Reliability will be increased as well. For example: if in the future for some reason vendor will decide to change names and number of frameworks produced during Carthage build.

Rome version: 0.12.0.31 - Romam uno die non fuisse conditam.
OS and version: macOS 10.12.5 (16F73)

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants