-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rome does not upload framework if dependency name and framework name does not match. #94
Comments
Hi, should be already addressed by adding name aliases in your Repository map. For Reachability.swift specify [RepositoryMap] See https://github.com/blender/Rome#multiple-aliases Does this help @vgorloff ? Bottom line:
for example:
Romefile
And you are done.
for example: for example:
Romefile , note that there is no entry for Alamofire
|
Thank you! My bad. I did not know/read about Multiple Aliases. Solution for my problem – is to write
|
I created enhancement #95. Feel free to close this issue.) Thank you! |
@vgorloff Thanks! I will updated the documentation to make the Multiple Aliases more obvious. |
Issue
Rome does not upload framework if dependency name and framework name does not match.
Steps to reproduce
Cartfile
dependency:github "ashleymills/Reachability.swift" == 3.0
Cartfile.resolved
with the contents likegithub "ashleymills/Reachability.swift" "v3"
rome upload --platform iOS --cache-prefix 8E3004b
Expected
8E3004b/Reachability.swift/.Reachability.swift.version-v3
8E3004b/Reachability.swift/iOS/Reachability.framework-v3.zip
8E3004b/Reachability.swift/iOS/Reachability.framework-v3.dSYM.zip
Observed
8E3004b/Reachability.swift/.Reachability.swift.version-v3
Additional info
Before upload (and download as well) Rome should read contents of version file
.Reachability.swift.version-v3
to get actual name of framework.For instance contents of
.Reachability.swift.version-v3
is the following:From the contents of the version file we can see that real name of framework will be "Reachability.framework", but not "Reachability.swift.framework".
Similar problem observed with following dependencies:
Rome version: 0.12.0.31 - Romam uno die non fuisse conditam.
OS and version: macOS 10.12.5 (16F73)
Thank you!
The text was updated successfully, but these errors were encountered: