This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
OpenID authentication support #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lemmmy
reviewed
Mar 27, 2024
There was a problem hiding this comment.
This isn't commentary on whether this feature would get merged in the first place (you can run shitty and serve the files separately, such that you can serve the UI with any OAuth/OIDC proxy of your choosing), but two quick comments after a glance at the code
|
After some discussion, we've decided to archive this project for the time being. You might want to consider this as an alternative: https://github.com/tycrek/ass |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with my IDP, hopefully works with tmpauth too. Authentication is important and I have no clue what I am doing, so there is probably a pitfall in the implementation somewhere.