Client: viewmodel: weapon sway and quake viewmodelpos (also added to models settings) #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implemented quake-styled viewmodelpos and weapon sway, added to settings
denz8028
changed the title
denz8028
changed the title
|
Not sure how the feature works (Maybe a video would be helpful) , but all I can say is that the formatting changes (whitespace, line breaks, etc.) are obscuring the core logic., I suggest removing those, so the reviewer can focus on the real changes and with that, you increase the odds of getting your PR merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented quake-styled viewmodelpos and weapon sway, added to settings