native icons decorative images guidance #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding base of decorative page
marshcooke
previously approved these changes
Jan 7, 2025
There was a problem hiding this comment.
I got mentally hung up on 2 things:
- The "keyboard" reproduction steps that mention "Screenreader ignores.." since KB users might not also be using a screen reader (on lines 7-9).
- The comma used between "adjacent" and "text" in line 45 - should it be removed or am I overthinking it?
And I know we have a lot of these throughout the site, so it shouldn't warrant a change but at least wanted to mention it:
- The double space between sentences on line 36.
Otherwise, this all looks great to me! I appreciate you putting this resource together!!
jzoo
reviewed
Jan 8, 2025
There was a problem hiding this comment.
we do not have Gherkin or WCAG for native right now so maybe comment out WCAG for now and for Gherkin we can just watch to see how it turns out as it is new. We are working on adding Gherkin for native so this will be a good test/start to see how it looks and turns out.
|
@jzoo updated with your helpful feedback |
jzoo
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only covering decorative image/icons for this.