Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have any of the listed boards so I was unable to directly test, but did a test on my own board and the debounce-api seemed to work fine.
Basic implementation is adding matrix_debounce() after matrix_scan(). The default implementation is
no debouncing
. This means all existing code works fine since all existing code does debouncing inside matrix_scan().After the basic implementation I ported of some of the keyboards.
Converters: Don't have debouncing, so no change required.
alps64: I don't have this keyboard. Compiles.
fc660c: Doesn't seem to debounce? So no change
fc980c: Doesn't seem to debounce? So no change
GH60: I don't have a gh60, but i used my own keyboard with different pin layout and it seemed to work fine. Compiles.
hbkb: I don't have this. Compiles.
hhkb: Debounce algorithm is based on some weird timer so I left it.
infinity: Makefile doesn't work so I didn't attempt anything
infinity_chibios: Makefile doesn't work so I didn't attempt anything
kl27z_kbd: Makefile doesn't work so I didn't attempt anything
kl27z_onekey: Makefile doesn't work so I didn't attempt anything
mbed_onekey: Makefile doesn't work so I didn't attempt anything
onekey: No debouncing. So no change
stm32_f07_onekey: Makefile doesn't work so I didn't attempt anything
stm32_f103_onekey: Makefile doesn't work so I didn't attempt anything
teensy_lc_onekey: Makefile doesn't work so I didn't attempt anything
For all the things where makefile didn't work, I'm running Windows, and get message similar to: