Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debounce_API #531

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Debounce_API #531

wants to merge 7 commits into from

Conversation

alex-ong
Copy link
Contributor

I don't have any of the listed boards so I was unable to directly test, but did a test on my own board and the debounce-api seemed to work fine.

Basic implementation is adding matrix_debounce() after matrix_scan(). The default implementation is no debouncing. This means all existing code works fine since all existing code does debouncing inside matrix_scan().

After the basic implementation I ported of some of the keyboards.

Converters: Don't have debouncing, so no change required.

alps64: I don't have this keyboard. Compiles.

fc660c: Doesn't seem to debounce? So no change

fc980c: Doesn't seem to debounce? So no change

GH60: I don't have a gh60, but i used my own keyboard with different pin layout and it seemed to work fine. Compiles.

hbkb: I don't have this. Compiles.

hhkb: Debounce algorithm is based on some weird timer so I left it.

infinity: Makefile doesn't work so I didn't attempt anything

infinity_chibios: Makefile doesn't work so I didn't attempt anything

kl27z_kbd: Makefile doesn't work so I didn't attempt anything

kl27z_onekey: Makefile doesn't work so I didn't attempt anything

mbed_onekey: Makefile doesn't work so I didn't attempt anything

onekey: No debouncing. So no change

stm32_f07_onekey: Makefile doesn't work so I didn't attempt anything

stm32_f103_onekey: Makefile doesn't work so I didn't attempt anything

teensy_lc_onekey: Makefile doesn't work so I didn't attempt anything

For all the things where makefile didn't work, I'm running Windows, and get message similar to:

../../tmk_core/tool/chibios/chibios.mk:261: ../../tmk_core/tool/chibios/ChibiOS/os/common/startup/ARMCMx/compilers/GCC/rules.mk: No such file or directory
make: *** No rule to make target '../../tmk_core/tool/chibios/ChibiOS/os/common/startup/ARMCMx/compilers/GCC/rules.mk'.  Stop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant