-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci updates #313
Merged
Merged
Ci updates #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomato42
added
the
maintenance
issues related to making the project usable or testable
label
Feb 23, 2023
tomato42
force-pushed
the
ci-updates
branch
4 times, most recently
from
February 24, 2023 14:21
9b730c6
to
651661a
Compare
As Github actions is dropping support for Ubuntu-18.04 images and those are the only ones that support easy execution of python 3.3 and python 3.4 environments, support for py3.3 and 3.4 would be hard to ensure. For old systems python 2.6 and 2.7 support will remain.
as ubuntu-18.04 is no longer supported, we need to start using newer version
# Conflicts: # tox.ini
Since it's a test case, only one course of action is actually expected so there is no branch at this point, even if the with: never returns
we want to test both with and without openssl command present
neverpanic
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nitpick, otherwise lg2m.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CI configuration to keep it working
fixes #312