groups: avoid %kick-ing empty list of paths #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kicking empty list of paths means "kick subscription that triggered this event". This does mean that when constructing a path list of unknown size, you have to catch the empty list case to avoid falling into that specialized behavior. Here, we check for the empty list, and avoid emiting kicks (or facts) in that case.
|
Leaving a comment here for posterity: it is likely these seemingly unused subscriptions were kicked by the migration code in Yet another reason to do a thorough cleanup of the %groups agent (on my todo list!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kicking empty list of paths means "kick subscription that triggered this event". This does mean that when constructing a path list of unknown size, you have to catch the empty list case to avoid falling into that specialized behavior.
Here, we check for the empty list, and avoid emitting kicks (or facts) in that case.
(In practice, this resulted in the kick going into clay during an update reload, which failed without providing a clear trace or legible failure reason. Notably, clay's error handling only handles errors on the
/dripwire, crashing in other cases. Potentially not the right approach...)(Note also that the whole "cast" stuff here has been marked as potentially deprecated. So, somewhat surprising this codepath is being hit in the first place. As of yet unclear where/why it originates...)