Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix %groups scry mismatches #4490

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Fix %groups scry mismatches #4490

merged 3 commits into from
Mar 5, 2025
+13 −13

Conversation

mikolajpp
Copy link
Collaborator

This PR adjusts the %groups scry types to correspond to the actual result.

@mikolajpp mikolajpp requested review from arthyn and Fang- March 5, 2025 08:44
Fang-
Fang- approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, these look like stragglers. I'll say it again: surely it can't be that big of a research project to do code analysis to find all possible scries in a codebase... (^:

@mikolajpp mikolajpp merged commit 8bdd113 into develop Mar 5, 2025
1 check passed
@mikolajpp mikolajpp deleted the mp/better-groups branch March 5, 2025 09:02
@jamesacklin jamesacklin removed the desk label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fang- Fang-

@arthyn arthyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikolajpp @Fang- @jamesacklin