Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use type password on api key input #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

zuramai
Copy link

@zuramai zuramai commented Nov 17, 2023

API Key is a confidential data that should not be shown publicly, especially when we want to record the screen while trying to copy-paste the API Key to the website.

Copy link

vercel bot commented Nov 17, 2023

@zuramai is attempting to deploy a commit to the tldraw Team on Vercel.

A member of the Team first needs to authorize it.

@TodePond
Copy link
Collaborator

Hey we tried this, but it was causing some password managers to mess up and think that some text shapes were also passwords (for some reason). I can give it another test

@zuramai
Copy link
Author

zuramai commented Nov 17, 2023

Hi @TodePond, how about blurring the input text like this?

Screenshot 2023-11-17 at 20 02 02

@brunubarbosa
Copy link

it's not a problem when recording the screen since the password is not shown when the input is not focused and when focused it shows just part of the key, maybe just show even less?
Also, something I'd add to it a visual feedback indicating it has a key added (since the same UI is shown in both cases)

@steveruizok
Copy link

Addressed! Sort of. I think we'll do a big CTA and show a modal or something for the api key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants