perf: improve creating tfIdf with cache #433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve #353
While building indexes there is a call to creating TfIdf.
I noticed that the the getIdf() method only depends on the word and doesn't the other values remained constant, so I cached the result of getIdf() for different words and before calling it again I check if I already had the value.
This improved the performance significantly.
getTfIdf() performance:
Before: 1:52.468s. (maybe my sys is slow)
After: 9.021s
Checklist
Please review this checklist before submitting a pull request.
npm run test:all
)