Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pydantic-compat v0.2. #236

Merged
merged 1 commit into from
Dec 17, 2023
Merged

feat: support pydantic-compat v0.2. #236

merged 1 commit into from
Dec 17, 2023

Conversation

tlambert03
Copy link
Owner

pydantic-compat v0.2 will move where the Field metadata key is:
pyapp-kit/pydantic-compat#15

this prepares for that

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9a16286) 86.38% compared to head (5350ca4) 86.33%.

Files Patch % Lines
src/ome_types/_pydantic_compat.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   86.38%   86.33%   -0.05%     
==========================================
  Files          26       26              
  Lines        1256     1259       +3     
==========================================
+ Hits         1085     1087       +2     
- Misses        171      172       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 17, 2023

CodSpeed Performance Report

Merging #236 will not alter performance

Comparing future-proof-meta (5350ca4) with main (9a16286)

Summary

✅ 9 untouched benchmarks

@tlambert03 tlambert03 merged commit 994fe37 into main Dec 17, 2023
32 of 34 checks passed
@tlambert03 tlambert03 deleted the future-proof-meta branch December 17, 2023 13:49
@tlambert03 tlambert03 added the enhancement New feature or request label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant