Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #555 use get_random_secret_key #556

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

jonespm
Copy link
Member

@jonespm jonespm commented Oct 22, 2024

Noticed this when I was looking at #488. Prod uses hardcoded secrets and doesn't rely on this but this should be updated.

@jonespm jonespm requested review from lsloan and zqian October 22, 2024 20:51
@jonespm jonespm changed the title Fxies #555 use get_random_secret_key Fixes #555 use get_random_secret_key Oct 22, 2024
@jonespm jonespm linked an issue Oct 22, 2024 that may be closed by this pull request
Copy link
Member

@zqian zqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Member

@lsloan lsloan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a simple solution.

@jonespm jonespm merged commit 429ed7c into tl-its-umich-edu:master Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use get_random_secret_key rather than a hardcoded secret
3 participants