Fixes #488 - Adding env sample files #554
Conversation
| @@ -0,0 +1,22 @@ | |||
| #DEBUG=False | |||
There was a problem hiding this comment.
There are a couple of environment attributes defined in the docker-compose.yaml file, inside both web and database services. Can those be moved into the .env too?
There was a problem hiding this comment.
Good question. The master branch currently has…
- ALLOWED_HOSTS=*
- DEBUG=True
- DATABASE_URL=postgresql://admin:admin_pw@database/admin
- [email protected]
As I was working with the app in local dev., I had to set some values there for running the Twilio tests. I was thinking at the time that they should go in a config file as Matt does here. I think the values listed above could also go there.
| - DEBUG=True | ||
| - DATABASE_URL=postgresql://admin:admin_pw@database/admin | ||
| - [email protected] |
There was a problem hiding this comment.
As suggested in earlier comments, let's move these to .env, too.
There was a problem hiding this comment.
Sure we can move these, but I think having these might require that a .env file exists unless these are in the code. That's probably fine as a practice. I'd also update the README, I was still testing this to make sure there was nothing else and having it as draft.
This would only affect development but is really useful to have for development.
Leaving as draft while a few more values are researched and tested.