Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Support Web Extension (Firefox Extension) #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[WIP] Support Web Extension (Firefox Extension) #8

wants to merge 4 commits into from

Conversation

tksugimoto
Copy link
Owner

It does not work currently (Firefox 57.0.1).

Todo

  • Make it installable on firefox
  • Wait for web extension api to be able to open file URL
    tabs.create() - Mozilla | MDN

    For security reasons, in Firefox, this may not be a privileged URL. So passing any of the following URLs will fail:

    • file: URLs (i.e., files on the filesystem. However, to use a file packaged inside the extension, see below)
  • Change i18n message files
    • e.g.) disabled by Chrome

@tksugimoto
[Copy] Chrome拡張用ファイルを web-extension フォルダにコピー
fb52f32
@tksugimoto
[Update] manifest.json: Chrome拡張用のkeyを削除
a295e48
@tksugimoto
[Update] manifest.json: Chrome拡張用でしか使えないオプション（イベントページ）を削除
cd49c43
@tksugimoto
[Remove] Firefoxでは不要なインストール時の既存タブへの機能有効化処理
fc54141 
インストール時には全タブへ自動適用されるらしい
※ 開発用読み込み時のみの挙動かもしれないので要検証

備考（revertする時用）
Firefoxでは chrome.tabs.query で url検索する場合は tabs permissionが必要

tabs.query() - Mozilla | MDN
https://developer.mozilla.org/ja/Add-ons/WebExtensions/API/tabs/query

> 2. Fails if the extension doesn't have the tabs permission.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tksugimoto