Skip to content

[Demo] Incoming N-EVENT-REPORT RSP messages during release cause deadlock / exception #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tkim602 wants to merge 1 commit into
base: demo/pynetdicom-release-base
Choose a base branch
from
Open

[Demo] Incoming N-EVENT-REPORT RSP messages during release cause deadlock / exception #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions pynetdicom/dul.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,23 @@ def send_pdu(self, primitive: _PDUPrimitiveType) -> None:
* :class:`A_P_ABORT`
* :class:`P_DATA`
"""
# Don't send data primitives during association release/abort
# Sta7-Sta13 are release/abort states where we shouldn't send data
if isinstance(primitive, P_DATA) and self.state_machine.current_state in (
"Sta7",
"Sta8",
"Sta9",
"Sta10",
"Sta11",
"Sta12",
"Sta13",
):
LOGGER.warning(
"Attempted to send P-DATA primitive while in release/abort state "
f"'{self.state_machine.current_state}'. The primitive will be ignored."
)
return

# Event handler - ACSE sent primitive to the DUL service
if isinstance(primitive, (A_ASSOCIATE, A_RELEASE, A_ABORT, A_P_ABORT)):
evt.trigger(self.assoc, evt.EVT_ACSE_SENT, {"primitive": primitive})
Expand Down