WIP: Epic Games support #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotevo
commented
May 5, 2020
| id = idP; | ||
| icon = ""; | ||
| image = src.legendary_wrapper.get_image(id); | ||
| platforms.add(Platform.LINUX); |
There was a problem hiding this comment.
Platform is wrong. It should be Windows but by default GameHub use Wine for that.
dotevo
commented
May 5, 2020
| platforms.add(Platform.LINUX); | ||
|
|
||
| install_dir = null; | ||
| executable_path = "$game_dir/start.sh"; |
dotevo
commented
May 5, 2020
| info = Tables.Games.INFO.get(s); | ||
| info_detailed = Tables.Games.INFO_DETAILED.get(s); | ||
| icon = Tables.Games.ICON.get(s); | ||
| image = src.legendary_wrapper.get_image(id);//Tables.Games.IMAGE.get(s); |
There was a problem hiding this comment.
It change image with every reload. It should be possible to change it.
dotevo
commented
May 5, 2020
| EpicGames epic = (EpicGames)(game.source); | ||
|
|
||
| Utils.thread("EpicGamesGame.Installer", () => { | ||
| game.status = new Game.Status(Game.State.DOWNLOADING, game, null); |
There was a problem hiding this comment.
I should add progress bar change here. Should I create own Game.State or use existing in Downloader.
dotevo
commented
May 5, 2020
|
|
||
| public class LegendaryWrapper | ||
| { | ||
| private Regex regex = /\*\s*([^(]*)\s\(App\sname:\s([a-zA-Z0-9]+),\sversion:\s([^)]*)\)/; |
There was a problem hiding this comment.
New legendary has csv output. It should be changed.
dotevo
commented
May 5, 2020
| var input = new DataOutputStream(process.get_stdin_pipe ()); | ||
| var output = new DataInputStream(process.get_stdout_pipe ()); | ||
| string? line = null; | ||
| input.put_string("y\n"); |
There was a problem hiding this comment.
-y for CLI will skip this question
dotevo
commented
May 5, 2020
| var input = new DataOutputStream(process.get_stdin_pipe ()); | ||
| var output = new DataInputStream(process.get_stdout_pipe ()); | ||
| string? line = null; | ||
| input.put_string("y\n"); |
There was a problem hiding this comment.
-y for CLI will skip this question
dotevo
force-pushed
the
feature/epicgames
branch
from
af94e50
to
4446b93
Compare
Implemented some other features in the client
|
This one is actively developed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #295. Work still in progress.
legendaryis installed to enable EpicGames GameSource