Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(printing): make sure printer is responding #1748

Closed
wants to merge 2 commits into from
Closed

fix(printing): make sure printer is responding #1748

wants to merge 2 commits into from

Conversation

hstievat
Copy link
Contributor

@hstievat hstievat commented Mar 7, 2025

Proposed changes

Checks to make sure the printer is responding before checking alerts.

Brief description of rationale

This will fix Einstein incorrectly being marked as working.

@hstievat hstievat requested a review from a team as a code owner March 7, 2025 20:47
alanzhu0
alanzhu0 requested changes Mar 11, 2025
View reviewed changes
Copy link
Member

@alanzhu0 alanzhu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr! can you fix the merge conflicts please?

alanzhu0
alanzhu0 requested changes Mar 11, 2025
View reviewed changes
Copy link
Member

@alanzhu0 alanzhu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you squash the 2 commits into 1?

@hstievat hstievat closed this Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanzhu0 alanzhu0 alanzhu0 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hstievat @alanzhu0