Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logs): fix bright rows even on dark mode (closes tjcsl#1642) #1699

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

aarushtools
Copy link
Member

Proposed changes

  • add dark/logs.scss
  • use css to style even table rows instead of js

Brief description of rationale

  • fixes issue where even rows were white instead of a darker color on dark mode

before (from the issue page):
image

after:
image

@aarushtools aarushtools force-pushed the logs-darkmode-fix branch 4 times, most recently from b97d978 to b764036 Compare July 1, 2024 23:49
@aarushtools aarushtools marked this pull request as ready for review July 1, 2024 23:57
@aarushtools aarushtools requested a review from a team as a code owner July 1, 2024 23:57
@aarushtools
Copy link
Member Author

Should I collectstatic and add those files into my commit or is it fine?

@aarushtools aarushtools changed the title fix(logs): rows are bright even on dark mode (closes tjcsl#1642) fix(logs): fix bright rows even on dark mode (closes tjcsl#1642) Jul 2, 2024
@coveralls
Copy link

Coverage Status

coverage: 79.447% (+0.04%) from 79.412%
when pulling b764036 on aarushtools:logs-darkmode-fix
into 1d1ff53 on tjcsl:dev.

@coveralls
Copy link

Coverage Status

coverage: 79.447% (+0.04%) from 79.412%
when pulling d0342ae on aarushtools:logs-darkmode-fix
into 1d1ff53 on tjcsl:dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants