-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: border-radius of comment-app #7
base: master
Are you sure you want to change the base?
Conversation
modify the border-radius for containers in comment-app into 4px
感謝發 PR,下面是 HackMD 留言區塊的 HTML: <div class="ui-comment-app small" id="hackmd-app">
<div id="comment-app">
<div class="open-comments">
...
</div>
</div>
</div> HackMD 本身的 reset CSS 就有 * {
box-sizing: border-box;
} 並且 CSS 選擇器 .open-comments {
border-radius: 4px;
} |
Modify the border-radius as the maintainer suggests.
Fix the boarder-radius of ui-comment-button-container into 6px
感謝修正! 你指的 .ui-comment-app .ui-comment-button-container.comment:not(.active):hover {
z-index: 1050;
background-color: white;
} 我會傾向將背景色設為透明,因為在原主題 hover 後變為白色背景也不會讓視覺有改變。 |
Revert to 38f78fe.
Set the background-color of .ui-comment-button-container.comment into transparent, to fix the behavior happening upon hover and active.
Add the parent of open-comments in the selector.
感謝建議! 將 PS. 抱歉上個回應沒有敘述清楚。前則回應當中的圖片是 active 的狀況(我那時沒有注意到 hover 會有同樣的問題)。 |
將留言區塊改為圓角方形,消除原本的白色角落。
修改前:
![image](https://user-images.githubusercontent.com/28527336/97156048-1f7f0380-17b1-11eb-9eb5-76f2dfe83b14.png)
修改後:
![image](https://user-images.githubusercontent.com/28527336/97156067-2574e480-17b1-11eb-9c88-9543a57c1615.png)