Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for __nesc_keyword_ function undeclared #16

Merged
merged 1 commit into from
May 24, 2013

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented May 12, 2013

Added a check to see if the function name starts with __nesc_keyword_. If so, nesC now checks to see if the suffix function name is defined before throwing an error.

Also moved the #define for __nesc_keyword_ to a header file that both relevant files include.

Fixes issue #4

identifier result = new_identifier(parse_region, loc, id, NULL);

/* Check if the decl is prefaced with __nesc_keyword_ meaning we want to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this magic into lookup_id, to catch all uses, not just identifiers in expressions.

Added a check to semantics.c (function lookup_id()) to see if the
function name starts with __nesc_keyword_.  If so, nesC now checks to
see if the suffix function name is defined before throwing an error.

Also moved the #define for __nesc_keyword_ to a header file that both
relevant files include.

Fixes issue tinyos#4
@bradjc
Copy link
Contributor Author

bradjc commented May 23, 2013

I moved this to lookup_id().

dgay42 added a commit that referenced this pull request May 24, 2013
Fix for __nesc_keyword_ function undeclared
@dgay42 dgay42 merged commit 9db5b5d into tinyos:master May 24, 2013
@bradjc bradjc deleted the nesc-keyword branch May 24, 2013 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants